netdev - Re: [PATCH 04/15] ethernet: aurora: nb8800: add missing of_node_put after calling of_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Jul 2016 23:13:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	peter.chen@....com
Cc:	netdev@...r.kernel.org, vbridger@...nsource.altera.com,
	isubramanian@....com, kchudgar@....com, yisen.zhuang@...wei.com,
	salil.mehta@...wei.com, thomas.petazzoni@...e-electrons.com,
	sergei.shtylyov@...entembedded.com, peppe.cavallaro@...com,
	alexandre.torgue@...com, mugunthanvnm@...com, tremyfr@...il.com,
	wxt@...k-chips.com, arnd@...db.de, david.daney@...ium.com,
	huangdaode@...ilicon.com, jszhang@...vell.com
Subject: Re: [PATCH 04/15] ethernet: aurora: nb8800: add missing
 of_node_put after calling of_parse_phandle

From: Peter Chen <peter.chen@....com>
Date: Wed, 27 Jul 2016 10:20:37 +0800

> diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
> index 0d4ea92..d15d96b 100644
> --- a/drivers/net/ethernet/aurora/nb8800.c
> +++ b/drivers/net/ethernet/aurora/nb8800.c
> @@ -1006,6 +1006,7 @@ static int nb8800_stop(struct net_device *dev)
>  
>  	netif_stop_queue(dev);
>  	napi_disable(&priv->napi);
> +	of_node_put(priv->phy_node);
>  
>  	nb8800_dma_stop(dev);
>  	nb8800_mac_rx(dev, false);

This is broken.  The priv->phy_node reference is taken in the probe function,
therefore you have to drop that reference in the "remove" function not the
"stop" function.

I'm just looking over basic details of this patch series, and along with some
other feedback you've received, it looks like you really didn't put a lot of
auditing into the changes you are making.

Please go over this series one more time and resubmit the entire thing after
everything is sorted out and double-checked.

Thank you.