netdev - Re: [PATCH] tcp-tso: fix faulty logic in tcp_tso_should

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Aug 2016 12:09:08 +0800
From:	Changli Gao <xiaosuo@...il.com>
To:	Liang Ge <lungothrin@...il.com>
Cc:	edumazet@...gle.com, Herbert Xu <herbert@...dor.apana.org.au>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH] tcp-tso: fix faulty logic in tcp_tso_should_defer

On Thu, Aug 4, 2016 at 12:01 PM, Liang Ge <lungothrin@...il.com> wrote:
>
> code does not match comment
>
>         head = tcp_write_queue_head(sk);
>         skb_mstamp_get(&now);
>         age = skb_mstamp_us_delta(&now, &head->skb_mstamp);
>         /* If next ACK is likely to come too late (half srtt), do not defer */
>         if (age < (tp->srtt_us >> 4))
>                 goto send_now;
>
> This bug will cause TSO packets being transmitted too early, and force
> software to tear them apart.
>
> When ack clocking is likely to broke, this check will try to push out
> some EXTRA probe the first chance possible. Some transmission has
> already happened due to Eric's work.
>
> This patch fix the check.
> ---

Reviewed-by: Changli Gao <xiaosuo@...il.com>



-- 
Regards,
Changli Gao(xiaosuo@...il.com)