netdev - RE: [PATCH] net: arc_emac: add missing of_node_put() in arc_emac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 4 Aug 2016 06:20:46 +0000
From:	Peter Chen <peter.chen@....com>
To:	Wei Yongjun <weiyj.lk@...il.com>,
	"David S . Miller" <davem@...emloft.net>,
	Alexander Kochetkov <al.kochet@...il.com>,
	"Philippe Reynes" <tremyfr@...il.com>,
	Caesar Wang <wxt@...k-chips.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] net: arc_emac: add missing of_node_put() in
 arc_emac_probe()

 
>
>Signed-off-by: Wei Yongjun <weiyj.lk@...il.com>
>---
> drivers/net/ethernet/arc/emac_main.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ethernet/arc/emac_main.c
>b/drivers/net/ethernet/arc/emac_main.c
>index 4bff0f3..b0da969 100644
>--- a/drivers/net/ethernet/arc/emac_main.c
>+++ b/drivers/net/ethernet/arc/emac_main.c
>@@ -771,8 +771,10 @@ int arc_emac_probe(struct net_device *ndev, int interface)
> 	priv->dev = dev;
>
> 	priv->regs = devm_ioremap_resource(dev, &res_regs);
>-	if (IS_ERR(priv->regs))
>-		return PTR_ERR(priv->regs);
>+	if (IS_ERR(priv->regs)) {
>+		err = PTR_ERR(priv->regs);
>+		goto out_put_node;
>+	}
>
> 	dev_dbg(dev, "Registers base address is 0x%p\n", priv->regs);

Thanks, I missed that error path.

Reviewed-by: Peter Chen <peter.chen@....com>

Peter