netdev - RE: [PATCH net-next 13/18] liquidio support for new device cn23xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Aug 2016 16:04:53 +0000
From:	Yuval Mintz <Yuval.Mintz@...gic.com>
To:	Raghu Vatsavayi <rvatsavayi@...iumnetworks.com>,
	David Miller <davem@...emloft.net>
CC:	netdev <netdev@...r.kernel.org>,
	Derek Chickles <derek.chickles@...iumnetworks.com>,
	Satanand Burla <satananda.burla@...iumnetworks.com>,
	Felix Manlunas <felix.manlunas@...iumnetworks.com>,
	Raghu Vatsavayi <raghu.vatsavayi@...iumnetworks.com>
Subject: RE: [PATCH net-next  13/18] liquidio support for new device cn23xx

> +static void cn23xx_bar1_idx_setup(struct octeon_device *oct, u64 core_addr,
...
> +	if (valid == 0) {
!valid

...
> +		WRITE_ONCE(bar1, lio_pci_readq(
> +		    oct, CN23XX_PEM_BAR1_INDEX_REG(oct->pcie_port, idx)));
> +		lio_pci_writeq(oct, (READ_ONCE(bar1) & 0xFFFFFFFEULL),
> +			       CN23XX_PEM_BAR1_INDEX_REG(oct->pcie_port,
> idx));
> +		WRITE_ONCE(bar1, lio_pci_readq(
> +		    oct, CN23XX_PEM_BAR1_INDEX_REG(oct->pcie_port, idx)));
Indentation issues?

> +static u32 cn23xx_update_read_index(struct octeon_instr_queue *iq) {
...
> +	/* reset the cnt as a part of napi enable interrupt or check_iq_db */
> +	/*writeq(pkt_in_done | CN23XX_INTR_RESEND, iq->inst_cnt_reg);*/
Looks like this comment should be removed.