netdev - Re: [patch iproute2 1/2] devlink: write usage help messages to stderr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Aug 2016 08:56:54 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, idosch@...lanox.com,
	eladr@...lanox.com, yotamg@...lanox.com, nogahf@...lanox.com,
	ogerlitz@...lanox.com
Subject: Re: [patch iproute2 1/2] devlink: write usage help messages to
 stderr

On Mon, 8 Aug 2016 09:19:21 +0200
Jiri Pirko <jiri@...nulli.us> wrote:

> Sat, Jul 23, 2016 at 06:46:59PM CEST, stephen@...workplumber.org wrote:
> >On Fri, 22 Jul 2016 18:34:29 +0200
> >Jiri Pirko <jiri@...nulli.us> wrote:
> >  
> >> From: Jiri Pirko <jiri@...lanox.com>
> >> 
> >> In order to not confuse reader, write help messages into stderr.
> >> 
> >> Signed-off-by: Jiri Pirko <jiri@...lanox.com>  
> >
> >This does make devlink consistent with other parts of iproute2.
> >But the most common coding standards, back to Unix, and GNU are
> >that help messages should go to stdout so that:
> >  $ ip -h | more
> >would work as expected.  
> 
> The thing is I wanted to make stdout only for json. Putting non-json
> help out there does not look correct to me. Is it?
> 

I applied both of these patches, just wanted to mention that iproute2 is not
following the GNU convention. At this point, it really doesn't matter, there
are arguments to be made for both behaviors.