[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 08 Aug 2016 13:08:40 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: paul.gortmaker@...driver.com
Cc: netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH -net] net/ethernet: tundra: fix dump_eth_one warning in
tsi108_eth
From: Paul Gortmaker <paul.gortmaker@...driver.com>
Date: Thu, 4 Aug 2016 16:07:58 -0400
> The call site for this function appears as:
>
> #ifdef DEBUG
> data->msg_enable = DEBUG;
> dump_eth_one(dev);
> #endif
>
> ...leading to the following warning for !DEBUG builds:
>
> drivers/net/ethernet/tundra/tsi108_eth.c:169:13: warning: 'dump_eth_one' defined but not used [-Wunused-function]
> static void dump_eth_one(struct net_device *dev)
> ^
>
> ...when using the arch/powerpc/configs/mpc7448_hpc2_defconfig
>
> Put the function definition under the same #ifdef as the call site
> to avoid the warning.
>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: netdev@...r.kernel.org
> Cc: linuxppc-dev@...ts.ozlabs.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
Applied, thanks.
Powered by blists - more mailing lists