netdev - Re: [PATCH 1/2] net: davinci_cpdma: reduce time holding ctlr->lock in cpdma_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Aug 2016 13:57:25 +0530
From:	Mugunthan V N <mugunthanvnm@...com>
To:	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Grygorii Strashko <grygorii.strashko@...com>
CC:	<linux-omap@...r.kernel.org>, <netdev@...r.kernel.org>,
	<kernel@...gutronix.de>
Subject: Re: [PATCH 1/2] net: davinci_cpdma: reduce time holding ctlr->lock in
 cpdma_control_set

On Tuesday 26 July 2016 05:32 PM, Uwe Kleine-König wrote:
> The only user of cpdma_control_set (i.e. cpsw_ndo_open) doesn't check
> the return code, so it doesn't matter, which error triggers. So the
> checks that are independant of the fields protected by ctlr->lock can be
> moved out of the critical section.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Mugunthan V N <mugunthanvnm@...com>

Regards
Mugunthan V N