lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 09 Aug 2016 21:51:28 -0700 (PDT) From: David Miller <davem@...emloft.net> To: makita.toshiaki@....ntt.co.jp Cc: stephen@...workplumber.org, netdev@...r.kernel.org, bridge@...ts.linux-foundation.org, roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com Subject: Re: [PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp> Date: Thu, 4 Aug 2016 11:11:19 +0900 > Adding fdb entries pointing to the bridge device uses fdb_insert(), > which lacks various checks and does not respect added_by_user flag. > > As a result, some inconsistent behavior can happen: > * Adding temporary entries succeeds but results in permanent entries. > * Same goes for "dynamic" and "use". > * Changing mac address of the bridge device causes deletion of > user-added entries. > * Replacing existing entries looks successful from userspace but actually > not, regardless of NLM_F_EXCL flag. > > Use the same logic as other entries and fix them. > > Fixes: 3741873b4f73 ("bridge: allow adding of fdb entries pointing to the bridge device") > Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp> Applied, thanks.
Powered by blists - more mailing lists