netdev - Re: [PATCH v1 1/1] pptp: Refactor the struct and macros of PPTP codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Aug 2016 12:51:54 -0600
From:	Philp Prindeville <philipp@...fish-solutions.com>
To:	fgao@...vckh6395k16k5.yundunddos.com, davem@...emloft.net,
	stephen@...workplumber.org, pshelar@...ira.com,
	tom@...bertland.com, xeb@...l.ru, netdev@...r.kernel.org
Cc:	gfree.wind@...il.com
Subject: Re: [PATCH v1 1/1] pptp: Refactor the struct and macros of PPTP codes


On 08/12/2016 10:30 AM, fgao@...vckh6395k16k5.yundunddos.com wrote:
> From: Gao Feng <fgao@...ai8.com>
>
> 1. Use struct gre_base_hdr directly in pptp_gre_header instead of
> duplicated members;
> 2. Use existing macros like GRE_KEY, GRE_SEQ, and so on instead of
> duplicated macros defined by PPTP;
> 3. Add new macros like GRE_IS_ACK/SEQ and so on instead of
> PPTP_GRE_IS_A/S and so on;
>
> Signed-off-by: Gao Feng <fgao@...ai8.com>
>

Reviewed-by: Philip Prindeville <philipp@...fish-solutions.com>