netdev - Re: [PATCH net-next V2 2/5] flow_dissector: Get vlan priority in addition to vlan id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Aug 2016 09:25:24 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Hadar Hen Zion <hadarh@...lanox.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Jiri Pirko <jiri@...lanox.com>,
	Amir Vadai <amirva@...lanox.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Tom Herbert <tom@...bertland.com>
Subject: Re: [PATCH net-next V2 2/5] flow_dissector: Get vlan priority in
 addition to vlan id

Wed, Aug 17, 2016 at 12:36:11PM CEST, hadarh@...lanox.com wrote:
>Add vlan priority check to the flow dissector by adding new flow
>dissector struct, flow_dissector_key_vlan which includes vlan tag
>fields.
>
>vlan_id and flow_label fields were under the same struct
>(flow_dissector_key_tags). It was a convenient setting since struct
>flow_dissector_key_tags is used by struct flow_keys and by setting
>vlan_id and flow_label under the same struct, we get precisely 24 or 48
>bytes in flow_keys from flow_dissector_key_basic.
>
>Now, when adding vlan priority support, the code will be cleaner if
>flow_label and vlan tag won't be under the same struct anymore.
>
>Signed-off-by: Hadar Hen Zion <hadarh@...lanox.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>