netdev - Re: [PATCH -next] vmxnet3: fix non static symbol warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Aug 2016 10:13:42 -0700
From:   Shrikrishna Khare <skhare@...i-linux.eng.vmware.com>
To:     Wei Yongjun <weiyj.lk@...il.com>
CC:     Shrikrishna Khare <skhare@...are.com>,
        "VMware, Inc." <pv-drivers@...are.com>,
        Wei Yongjun <weiyongjun1@...wei.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH -next] vmxnet3: fix non static symbol warning



On Tue, 23 Aug 2016, Wei Yongjun wrote:

> From: Wei Yongjun <weiyongjun1@...wei.com>
>
> Fixes the following sparse warning:
>
> drivers/net/vmxnet3/vmxnet3_drv.c:1645:1: warning:
> symbol 'vmxnet3_rq_destroy_all_rxdataring' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Thanks for catching and fixing this. The fix looks good. But, could you 
please send this against net tree instead of net-next?


> ---
> drivers/net/vmxnet3/vmxnet3_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 4244b9d..2fd93b4 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -1641,7 +1641,7 @@ static void vmxnet3_rq_destroy(struct vmxnet3_rx_queue *rq,
> 	}
> }
>
> -void
> +static void
> vmxnet3_rq_destroy_all_rxdataring(struct vmxnet3_adapter *adapter)
> {
> 	int i;
>
>
>
>