netdev - Re: [PATCH 1/1] net: add killer E2500 device id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Aug 2016 11:58:14 +0200
From:   Sabrina Dubroca <sd@...asysnail.net>
To:     Owen Lin <olin@...etnetworks.com>
Cc:     "johannes@...solutions.net" <johannes@...solutions.net>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/1] net: add killer E2500 device id

Hi Owen,

2016-08-25, 03:33:11 +0000, Owen Lin wrote:
> Add Killer E2500 device ID in alx driver.
> 
> Signed-off-by: Owen Lin olin@...etnetworks.com
> 
> --------------------------------------------------------------------------------

This line shouldn't be here (it will end up in the commit message).

> diff -up1rN alx_orig/main.c alx/main.c
> --- alx_orig/main.c	2016-08-25 11:12:34.170447500 +0800
> +++ alx/main.c	2016-08-25 11:24:12.026853000 +0800

That patch won't apply.  The patch should be generated from the root
directory, and include the full path of the files you're modifying, so
that the patch can be applied from the root directory of the kernel
tree.  i.e. the paths should be of the form

    a/drivers/net/ethernet/atheros/alx/main.c

The easiest way to create patches that apply properly is to use the
git tree and the `git format-patch` tool.

Thanks,

-- 
Sabrina