netdev - Re: [PATCH net] rps: flow_dissector: Fix uninitialized flow_keys used in __skb_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2016 14:28:35 +0800
From:   Gao Feng <fgao@...ai8.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Philp Prindeville <philipp@...fish-solutions.com>,
        Tom Herbert <tom@...bertland.com>,
        Alex Duyck <aduyck@...antis.com>, amir@...ai.me,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] rps: flow_dissector: Fix uninitialized flow_keys used
 in __skb_get_hash possibly

On Wed, Aug 31, 2016 at 12:16 PM, Gao Feng <fgao@...ai8.com> wrote:
> On Wed, Aug 31, 2016 at 12:14 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>> On Wed, 2016-08-31 at 10:56 +0800, fgao@...ai8.com wrote:
>>> From: Gao Feng <fgao@...ai8.com>
>>>
>>> The original codes depend on that the function parameters are evaluated from
>>> left to right. But the parameter's evaluation order is not defined in C
>>> standard actually.
>>>
>>> When flow_keys_have_l4(&keys) is invoked before ___skb_get_hash(skb, &keys,
>>> hashrnd) with some compilers or environment, the keys passed to
>>> flow_keys_have_l4 is not initialized.
>>>
>>> Signed-off-by: Gao Feng <fgao@...ai8.com>
>>> ---
>>
>> Good catch, please add
>>
>> Fixes: 6db61d79c1e1 ("flow_dissector: Ignore flow dissector return value from ___skb_get_hash")
>> Acked-by: Eric Dumazet <edumazet@...gle.com>
>>
>>
>
> Add it into the description and resend the patch again?
>
> Best Regards
> Feng

Hi Eric,

I have sent the update "v2" patch which has the description "Fixes:
6db61d79c1e1 ("flow_dissector: Ignore flow dissector return value from
___skb_get_hash")".
Could you help review it again please?

Best Regards
Feng