lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 07 Sep 2016 07:14:20 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: Hadar Hen Zion <hadarh@...lanox.com> Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, Jiri Pirko <jiri@...lanox.com>, Jiri Benc <jbenc@...hat.com>, Jamal Hadi Salim <jhs@...atatu.com>, Shmulik Ladkani <shmulik.ladkani@...il.com>, Tom Herbert <tom@...bertland.com>, Eric Dumazet <edumazet@...gle.com>, Cong Wang <xiyou.wangcong@...il.com>, Amir Vadai <amirva@...lanox.com>, Or Gerlitz <ogerlitz@...lanox.com>, Amir Vadai <amir@...ai.me> Subject: Re: [PATCH net-next V6 4/4] net/sched: Introduce act_tunnel_key On Wed, 2016-09-07 at 11:08 +0300, Hadar Hen Zion wrote: > From: Amir Vadai <amir@...ai.me> > > +static int tunnel_key_init(struct net *net, struct nlattr *nla, > + struct nlattr *est, struct tc_action **a, > + int ovr, int bind) > +{ > + struct tc_action_net *tn = net_generic(net, tunnel_key_net_id); > + struct nlattr *tb[TCA_TUNNEL_KEY_MAX + 1]; > + struct metadata_dst *metadata = NULL; > + struct tc_tunnel_key *parm; > + struct tcf_tunnel_key *t; > + struct tcf_tunnel_key_params *params_old; > + struct tcf_tunnel_key_params *params_new; > + __be64 key_id; > + bool exists = false; > + int ret = 0; > + int err; We try for new code to avoid reverse Christmas tree ;) -> + struct tc_action_net *tn = net_generic(net, tunnel_key_net_id); + struct nlattr *tb[TCA_TUNNEL_KEY_MAX + 1]; + struct tcf_tunnel_key_params *params_old; + struct tcf_tunnel_key_params *params_new; + struct metadata_dst *metadata = NULL; + struct tc_tunnel_key *parm; + struct tcf_tunnel_key *t; + bool exists = false; + __be64 key_id; + int ret = 0; + int err; Other than this, code looks fine to me, thanks.
Powered by blists - more mailing lists