netdev - Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Sep 2016 11:40:17 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Arnd Bergmann <arnd@...db.de>, netdev@...r.kernel.org,
        Alexei Starovoitov <ast@...nel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Alexei Starovoitov <ast@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH, net-next] perf, bpf: fix conditional call to
 bpf_overflow_handler


* Daniel Borkmann <daniel@...earbox.net> wrote:

> On 09/08/2016 09:01 AM, Ingo Molnar wrote:
> >* Peter Zijlstra <peterz@...radead.org> wrote:
> >>On Thu, Sep 08, 2016 at 08:30:52AM +0200, Ingo Molnar wrote:
> >>>>Thanks for the fix. Just saw build bot complaining last night and
> >>>>by the morning your fix is already here. Thanks!
> >>>
> >>>Guys, this is the first time I saw this patch (and presumably there's some other
> >>>patch as well?) - could you please submit it properly for review and get an
> >>>Acked-by from one of the perf maintainers before appying it?
> >>
> >>I was involved with the original patch and Ack'ed it.
> >
> >Neither the Ack nor the Cc:s were preserved in the net-next commit:
> >
> >   aa6a5f3cb2b2 ("perf, bpf: add perf events core support for BPF_PROG_TYPE_PERF_EVENT programs")
> 
> Afaik patchwork doesn't pick up Acks when they are against the
> cover letter of a series. [...]

That's unfortunate - I usually add them in manually.

> [...] For the series that includes mentioned commit, Peter's Ack is here:
> 
>     4df20483ab28 ("Merge branch 'bpf-perf-hw-sw-events'")

Looks good!

Thanks,

	Ingo