netdev - Re: [PATCH net-next] ipv4: accept u8 in IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 08 Sep 2016 06:31:14 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Francesco Fusco <fusco@...p.org>,
        Maciej Żenczykowski <maze@...gle.com>
Subject: Re: [PATCH net-next] ipv4: accept u8 in IP_TOS ancillary data

On Thu, 2016-09-08 at 11:15 +0200, Jesper Dangaard Brouer wrote:
> On Wed, 07 Sep 2016 21:52:56 -0700
> Eric Dumazet <eric.dumazet@...il.com> wrote:
> 
> > From: Eric Dumazet <edumazet@...gle.com>
> > 
> > In commit f02db315b8d8 ("ipv4: IP_TOS and IP_TTL can be specified as
> > ancillary data") Francesco added IP_TOS values specified as integer.
> > 
> > However, kernel sends to userspace (at recvmsg() time) an IP_TOS value
> > in a single byte, when IP_RECVTOS is set on the socket.
> > 
> > It can be very useful to reflect all ancillary options as given by the
> > kernel in a subsequent sendmsg(), instead of aborting the sendmsg() with
> > EINVAL after Francesco patch.
> > 
> > So this patch extends IP_TOS ancillary to accept an u8, so that an UDP
> > server can simply reuse same ancillary block without having to mangle
> > it.
> > 
> > Jesper can then augment
> > https://github.com/netoptimizer/network-testing/blob/master/src/udp_example02.c
> > to add TOS reflection ;)
> 
> This is actually your old program ;-)
> Do I need to change anything, as I'm just bouncing the packet back with sendmsg() ?

I guess you want to add an option and if this option is requested by the
user, add :

	setsockopt(fd, SOL_IP, IP_PKTINFO, &on, sizeof(on));
+	if (tos_reflect)
+		setsockopt(fd, SOL_IP, IP_RECVTOS, &on, sizeof(on));

before the loop doing the recvmsg()/sendmsg() calls.

Thanks !