[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 8 Sep 2016 22:59:29 -0700
From: Cong Wang <xiyou.wangcong@...il.com>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: Eric Dumazet <eric.dumazet@...il.com>,
David Miller <davem@...emloft.net>,
Linux Kernel Network Developers <netdev@...r.kernel.org>,
Jamal Hadi Salim <jhs@...atatu.com>,
John Fastabend <john.fastabend@...il.com>,
Hadar Hen Zion <hadarh@...lanox.com>,
Amir Vadai <amirva@...lanox.com>
Subject: Re: [PATCH net] net_sched: act_mirred: full rcu conversion
On Thu, Sep 8, 2016 at 10:48 PM, Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> imo the deliberate small race in Eric's initial lock removal in mirred
> was a good design choice. I think he did this patch only to
> silence the complains with the code instead of arguing with words.
> imo the initial code is good as-is. This patch is also a nice improvement,
> but certainly not mandatory. 'face palm' is unnecessary.
LOL, to summarize your words:
1) not changing the current code is good
2) changing the current code is good too
Powered by blists - more mailing lists