netdev - Re: [PATCH net-next 05/14] tcp: track data delivery rate for a TCP connection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Sep 2016 05:38:20 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Neal Cardwell <ncardwell@...gle.com>
Cc:     kbuild-all@...org, David Miller <davem@...emloft.net>,
        netdev@...r.kernel.org, Yuchung Cheng <ycheng@...gle.com>,
        Van Jacobson <vanj@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>,
        Nandita Dukkipati <nanditad@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>
Subject: Re: [PATCH net-next 05/14] tcp: track data delivery rate for a TCP
 connection

Hi Yuchung,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Neal-Cardwell/tcp-BBR-congestion-control-algorithm/20160917-025323
config: cris-etrax-100lx_v2_defconfig (attached as .config)
compiler: cris-linux-gcc (GCC) 6.2.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=cris 

All warnings (new ones prefixed by >>):

   In file included from net/ipv4/route.c:103:0:
>> include/net/tcp.h:769:11: warning: 'packed' attribute ignored for field of type 'struct skb_mstamp' [-Wattributes]
       struct skb_mstamp first_tx_mstamp __packed;
              ^~~~~~~~~~
   include/net/tcp.h:771:11: warning: 'packed' attribute ignored for field of type 'struct skb_mstamp' [-Wattributes]
       struct skb_mstamp delivered_mstamp __packed;
              ^~~~~~~~~~

vim +769 include/net/tcp.h

   753	#define TCPCB_TAGBITS		0x07	/* All tag bits			*/
   754	#define TCPCB_REPAIRED		0x10	/* SKB repaired (no skb_mstamp)	*/
   755	#define TCPCB_EVER_RETRANS	0x80	/* Ever retransmitted frame	*/
   756	#define TCPCB_RETRANS		(TCPCB_SACKED_RETRANS|TCPCB_EVER_RETRANS| \
   757					TCPCB_REPAIRED)
   758	
   759		__u8		ip_dsfield;	/* IPv4 tos or IPv6 dsfield	*/
   760		__u8		txstamp_ack:1,	/* Record TX timestamp for ack? */
   761				eor:1,		/* Is skb MSG_EOR marked? */
   762				unused:6;
   763		__u32		ack_seq;	/* Sequence number ACK'd	*/
   764		union {
   765			struct {
   766				/* There is space for up to 24 bytes */
   767				__u32 in_flight;/* Bytes in flight when packet sent */
   768				/* start of send pipeline phase */
 > 769				struct skb_mstamp first_tx_mstamp __packed;
   770				/* when we reached the "delivered" count */
   771				struct skb_mstamp delivered_mstamp __packed;
   772				/* pkts S/ACKed so far upon tx of skb, incl retrans: */
   773				__u32 delivered;
   774			} tx;   /* only used for outgoing skbs */
   775			union {
   776				struct inet_skb_parm	h4;
   777	#if IS_ENABLED(CONFIG_IPV6)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (8333 bytes)