netdev - RE: [RFC 06/11] Add support for QP verbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Sep 2016 09:00:26 +0000
From:   "Amrani, Ram" <Ram.Amrani@...ium.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     "dledford@...hat.com" <dledford@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Yuval.Mintz@...gic.com" <Yuval.Mintz@...gic.com>,
        "Ariel.Elior@...gic.com" <Ariel.Elior@...gic.com>,
        "Michal.Kalderon@...gic.com" <Michal.Kalderon@...gic.com>,
        "rajesh.borundia@...gic.com" <rajesh.borundia@...gic.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [RFC 06/11] Add support for QP verbs

> > +
> > +	rc = ib_get_cached_gid(ibqp->device, attr->ah_attr.port_num,
> > +			       attr->ah_attr.grh.sgid_index, &gid, &gid_attr);
> > +	if (!rc && !memcmp(&gid, &zgid, sizeof(gid)))
> > +		rc = -ENOENT;
> > +
> > +	if (!rc && gid_attr.ndev) {

<snip>

> > +		}
> > +	}
> > +	if (rc)
> > +		return -EINVAL;
> 
> I think it is better to check "rc" right after call to ib_get_cached_gid().

Somehow this e-mail slipped.
Thanks, will update.