netdev - Re: [PATCH v3 2/2] netfilter: Create revision 2 of xt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 25 Sep 2016 14:58:45 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Vishwanath Pai <vpai@...mai.com>
Cc:     Jan Engelhardt <jengelh@...i.de>, kaber@...sh.net,
        kadlec@...ckhole.kfki.hu, johunt@...mai.com,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, pai.vishwain@...il.com
Subject: Re: [PATCH v3 2/2] netfilter: Create revision 2 of xt_hashlimit to
 support higher pps rates

On Sun, Sep 25, 2016 at 01:35:01PM +0200, Pablo Neira Ayuso wrote:
> On Thu, Sep 22, 2016 at 02:39:45PM -0400, Vishwanath Pai wrote:
> > Thanks for pointing this out, I will reorder the fields to:
> > 
> > struct hashlimit_cfg2 {
> > 	__u64 avg;    /* Average secs between packets * scale */
> > 	__u64 burst;
> > 	__u32 mode; /* bitmask of XT_HASHLIMIT_HASH_* */
> > 
> > This should fix the hole and avoid padding.
> 
> I have manually mangled this here, and applied, to get this change in
> this in merge window.
> 
> I also have to revert the rename of XT_HASHLIMIT_SCALE to
> XT_HASHLIMIT_SCALE_v1. This is exposed through uapi, this change would
> break userspace.

This requires that you rebase and resubmit your userspace patches for
iptables though.

Thanks for your patience to get this in, btw.