netdev - Re: [PATCH v4 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Sep 2016 11:30:50 +0900
From:   Maciej Żenczykowski <maze@...gle.com>
To:     Hannes Frederic Sowa <hannes@...essinduktion.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Linux NetDev <netdev@...r.kernel.org>,
        Erik Kline <ek@...gle.com>,
        Lorenzo Colitti <lorenzo@...gle.com>
Subject: Re: [PATCH v4 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval'

> Is seconds granular enough?

The only reason why one would ever want to go into fractions of
seconds would be some sort of unittesting with very low delays.

In any normal environment the max is going to be tens if not hundreds
or thousands of seconds.

Also note that the delay and interval (ie. not max interval) are also
currently exported in seconds, so having more granularity for
max_seconds is kind of pointless.

I have been considering whether I could make proc_dointvec_jiffies
accept floating point input (and output) though... although that seems
a little harder and probably out of scope of this change.