netdev - RE: [PATCH v2] mwifiex: report wakeup for wowlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Sep 2016 13:59:35 +0000
From:   Amitkumar Karwar <akarwar@...vell.com>
To:     Rajat Jain <rajatja@...gle.com>,
        Nishant Sarmukadam <nishants@...vell.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Wei-Ning Huang <wnhuang@...gle.com>,
        Brian Norris <briannorris@...gle.com>,
        Eric Caruso <ejcaruso@...omium.org>,
        "rajatxjain@...il.com" <rajatxjain@...il.com>
Subject: RE: [PATCH v2] mwifiex: report wakeup for wowlan

> From: Rajat Jain [mailto:rajatja@...gle.com]
> Sent: Wednesday, September 28, 2016 7:15 AM
> To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo; linux-
> wireless@...r.kernel.org; netdev@...r.kernel.org
> Cc: Rajat Jain; Wei-Ning Huang; Brian Norris; Eric Caruso;
> rajatxjain@...il.com
> Subject: [PATCH v2] mwifiex: report wakeup for wowlan
> 
> Enable notifying wakeup source to the PM core in case of a wake on
> wireless LAN event.
> 
> Signed-off-by: Wei-Ning Huang <wnhuang@...gle.com>
> Signed-off-by: Rajat Jain <rajatja@...gle.com>
> Tested-by: Wei-Ning Huang <wnhuang@...omium.org>
> Reviewed-by: Eric Caruso <ejcaruso@...omium.org>
> ---
> v2: Fix the commit log
> 
>  drivers/net/wireless/marvell/mwifiex/sdio.c | 8 ++++++++
> drivers/net/wireless/marvell/mwifiex/sdio.h | 1 +
>  2 files changed, 9 insertions(+)
> 
> diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c
> b/drivers/net/wireless/marvell/mwifiex/sdio.c
> index d3e1561..a5f63e4 100644
> --- a/drivers/net/wireless/marvell/mwifiex/sdio.c
> +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
> @@ -89,6 +89,9 @@ static irqreturn_t mwifiex_wake_irq_wifi(int irq, void
> *priv)
>  		disable_irq_nosync(irq);
>  	}
> 
> +	/* Notify PM core we are wakeup source */
> +	pm_wakeup_event(cfg->dev, 0);
> +
>  	return IRQ_HANDLED;
>  }
> 
> @@ -112,6 +115,7 @@ static int mwifiex_sdio_probe_of(struct device *dev,
> struct sdio_mmc_card *card)
>  					  GFP_KERNEL);
>  	cfg = card->plt_wake_cfg;
>  	if (cfg && card->plt_of_node) {
> +		cfg->dev = dev;
>  		cfg->irq_wifi = irq_of_parse_and_map(card->plt_of_node, 0);
>  		if (!cfg->irq_wifi) {
>  			dev_dbg(dev,
> @@ -130,6 +134,10 @@ static int mwifiex_sdio_probe_of(struct device
> *dev, struct sdio_mmc_card *card)
>  		}
>  	}
> 
> +	ret = device_init_wakeup(dev, true);
> +	if (ret)
> +		dev_err(dev, "fail to init wakeup for mwifiex");
> +
>  	return 0;
>  }
> 
> diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.h
> b/drivers/net/wireless/marvell/mwifiex/sdio.h
> index db837f1..07cdd23 100644
> --- a/drivers/net/wireless/marvell/mwifiex/sdio.h
> +++ b/drivers/net/wireless/marvell/mwifiex/sdio.h
> @@ -155,6 +155,7 @@
>  } while (0)
> 
>  struct mwifiex_plt_wake_cfg {
> +	struct device *dev;
>  	int irq_wifi;
>  	bool wake_by_wifi;
>  };
> --
> 2.8.0.rc3.226.g39d4020

Acked-by: Amitkumar Karwar <akarwar@...vell.com>

Regards,
Amitkumar