netdev - Re: [PATCH v2] net: fec: set mac address unconditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 03 Oct 2016 01:28:03 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     g.schenk@...elmann.de
Cc:     fugang.duan@....com, netdev@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH v2] net: fec: set mac address unconditionally

From: Gavin Schenk <g.schenk@...elmann.de>
Date: Fri, 30 Sep 2016 11:46:10 +0200

> If the mac address origin is not dt, you can only safely assign a mac
> address after "link up" of the device. If the link is off the clocks are
> disabled and because of issues assigning registers when clocks are off the
> new mac address cannot be written in .ndo_set_mac_address() on some soc's.
> This fix sets the mac address unconditionally in fec_restart(...) and
> ensures consistency between fec registers and the network layer.
> 
> Signed-off-by: Gavin Schenk <g.schenk@...elmann.de>
> Acked-by: Fugang Duan <fugang.duan@....com>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Fixes: 9638d19e4816 ("net: fec: add netif status check before set mac address")
> ---
> Changes since (implicit) v1:
> - reword commit log as suggested by Uwe
> - added Acks

Applied and queued up for -stable, thanks.