netdev - Re: [PATCH net-next] sctp: reuse sent_count to avoid retransmitted chunks for RTT measurements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2016 16:56:32 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        Vlad Yasevich <vyasevich@...il.com>, daniel@...earbox.net,
        davem@...emloft.net
Subject: Re: [PATCH net-next] sctp: reuse sent_count to avoid retransmitted
 chunks for RTT measurements

On Mon, Oct 10, 2016 at 02:48:25PM -0300, Marcelo Ricardo Leitner wrote:
> On Sat, Oct 08, 2016 at 11:36:05AM +0800, Xin Long wrote:
> > Now sctp uses chunk->resent to record if a chunk is retransmitted, for
> > RTT measurements with retransmitted DATA chunks. chunk->sent_count was
> > introduced to record how many times one chunk has been sent for prsctp
> > RTX policy before. We actually can know if one chunk is retransmitted
> > by checking chunk->sent_count is greater than 1.
> > 
> > This patch is to remove resent from sctp_chunk and reuse sent_count
> > to avoid retransmitted chunks for RTT measurements.
> > 
> > Signed-off-by: Xin Long <lucien.xin@...il.com>
> 
> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

Though you may have to resend later, as we are still in merge window and
we shouldn't be posting net-next patches during it.