netdev - Re: [PATCH net-next 5/6] qed: Allow chance for fast ramrod completions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2016 03:17:24 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Yuval.Mintz@...ium.com
Cc:     eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 5/6] qed: Allow chance for fast ramrod
 completions

From: "Mintz, Yuval" <Yuval.Mintz@...ium.com>
Date: Mon, 10 Oct 2016 06:33:05 +0000

> 
>> > +     while (iter_cnt--) {
>> > +             /* Validate we receive completion update */
>> >                smp_rmb();
>> >                if (comp_done->done == 1) {
>> >                        if (p_fw_ret)
>> >                                *p_fw_ret = comp_done->fw_return_code;
>> >                        return 0;
>> >                }
> 
>> Note that this smp_rmb() and accesses to ->done and ->fw_return_code are
>> racy.
> 
>> fw_return_code needs to be written _before_ done.
> 
> Thanks for catching this up.
> 
> Dave  - do you want me to re-spin for this?

Yes.