netdev - Re: [PATCH v3] iproute2: build nsid-name cache only for commands that need it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 9 Oct 2016 18:57:40 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Anton Aksola <aakso@....fi>
Cc:     netdev@...r.kernel.org, nicolas.dichtel@...nd.com,
        vadim4j@...il.com
Subject: Re: [PATCH v3] iproute2: build nsid-name cache only for commands
 that need it

On Tue, 20 Sep 2016 06:01:27 +0000
Anton Aksola <aakso@....fi> wrote:

> The calling of netns_map_init() before command parsing introduced
> a performance issue with large number of namespaces.
> 
> As commands such as add, del and exec do not need to iterate through
> /var/run/netns it would be good not no build the cache before executing
> these commands.
> 
> Example:
> unpatched:
> time seq 1 1000 | xargs -n 1 ip netns add
> 
> real    0m16.832s
> user    0m1.350s
> sys    0m15.029s
> 
> patched:
> time seq 1 1000 | xargs -n 1 ip netns add
> 
> real    0m3.859s
> user    0m0.132s
> sys    0m3.205s
> 
> Signed-off-by: Anton Aksola <aakso@....fi>
> ---
>  ip/ip_common.h                            |  1 +
>  ip/ipmonitor.c                            |  1 +
>  ip/ipnetns.c                              | 31 ++++++++++++++++++++++---------
>  testsuite/tests/ip/netns/set_nsid.t       | 22 ++++++++++++++++++++++
>  testsuite/tests/ip/netns/set_nsid_batch.t | 18 ++++++++++++++++++
>  5 files changed, 64 insertions(+), 9 deletions(-)
>  create mode 100755 testsuite/tests/ip/netns/set_nsid.t
>  create mode 100755 testsuite/tests/ip/netns/set_nsid_batch.t
> 

Applied to net-next (ie for 4.9)