netdev - Re: [PATCH 4/6] fjes: Implement debug mode for fjes driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Oct 2016 10:19:30 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     izumi.taku@...fujitsu.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 4/6] fjes: Implement debug mode for fjes driver

From: Taku Izumi <izumi.taku@...fujitsu.com>
Date: Tue, 11 Oct 2016 17:55:20 +0900

> This patch implements debug mode for fjes driver.
> You can get firmware activity information by enabling
> debug mode. This is useful for debugging.
> 
> To enable debug mode, write value of debugging mode to
> debug_mode file in debugfs:
> 
>   # echo 1 > /sys/kernel/debug/fjes/fjes.0/debug_mode
> 
> To disable debug mode, write 0 to debug_mode file in debugfs:
> 
>   # echo 0 > /sys/kernel/debug/fjes/fjes.0/debug_mode
> 
> Firmware activity information can be retrieved via
> /sys/kernel/debug/fjes/fjes.0/debug_data file.
> 
> Signed-off-by: Taku Izumi <izumi.taku@...fujitsu.com>

There is no reason to use debugfs for this, we have facilities such
as ETHTOOL_SET_DUMP et al. that you can use to implement this.