netdev - Re: [PATCH iproute2] devlink: Convert conditional in dl_argv_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Oct 2016 05:31:19 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, Phil Sutter <phil@....cc>
Subject: Re: [PATCH iproute2] devlink: Convert conditional in
 dl_argv_handle_port() to switch()

On Sun,  9 Oct 2016 10:14:18 +0800
Hangbin Liu <liuhangbin@...il.com> wrote:

> Discovered by Phil's covscan. The final return statement is never reached.
> This is not inherently clear from looking at the code, so change the
> conditional to a switch() statement which should clarify this.
> 
> CC: Phil Sutter <phil@....cc>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Applied thanks