netdev - Re: [PATCH] net: fec: drop check for clk==NULL before calling clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Oct 2016 14:20:45 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     u.kleine-koenig@...gutronix.de
Cc:     fugang.duan@....com, kernel@...gutronix.de, netdev@...r.kernel.org
Subject: Re: [PATCH] net: fec: drop check for clk==NULL before calling clk_*

From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Date: Thu, 20 Oct 2016 10:28:27 +0200

> clk_prepare, clk_enable and their counterparts (at least the common clk
> ones, but also most others) do check for the clk being NULL anyhow (and
> return 0 then), so there is no gain when the caller checks, too.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Applied to net-next.