lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Oct 2016 06:47:16 -0500 From: Tom Lendacky <thomas.lendacky@....com> To: Wei Yongjun <weiyj.lk@...il.com> CC: Wei Yongjun <weiyongjun1@...wei.com>, <netdev@...r.kernel.org> Subject: Re: [PATCH -next] amd-xgbe: Fix error return code in xgbe_probe() On 10/22/2016 09:35 AM, Wei Yongjun wrote: > From: Wei Yongjun <weiyongjun1@...wei.com> > > Fix to return error code -ENODEV from the DMA is not supported error > handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com> Acked-by: Tom Lendacky <thomas.lendacky@....com> > --- > drivers/net/ethernet/amd/xgbe/xgbe-main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-main.c b/drivers/net/ethernet/amd/xgbe/xgbe-main.c > index 667e120..6997f11 100644 > --- a/drivers/net/ethernet/amd/xgbe/xgbe-main.c > +++ b/drivers/net/ethernet/amd/xgbe/xgbe-main.c > @@ -613,6 +613,7 @@ static int xgbe_probe(struct platform_device *pdev) > attr = device_get_dma_attr(dev); > if (attr == DEV_DMA_NOT_SUPPORTED) { > dev_err(dev, "DMA is not supported"); > + ret = -ENODEV; > goto err_io; > } > pdata->coherent = (attr == DEV_DMA_COHERENT); >
Powered by blists - more mailing lists