lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Oct 2016 06:06:10 +0000 From: "Y.B. Lu" <yangbo.lu@....com> To: "Y.B. Lu" <yangbo.lu@....com>, Scott Wood <oss@...error.net>, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>, "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>, Arnd Bergmann <arnd@...db.de> CC: "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>, "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>, "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Mark Rutland <mark.rutland@....com>, Rob Herring <robh+dt@...nel.org>, Russell King <linux@....linux.org.uk>, Jochen Friedrich <jochen@...am.de>, Joerg Roedel <joro@...tes.org>, Claudiu Manoil <claudiu.manoil@...escale.com>, Bhupesh Sharma <bhupesh.sharma@...escale.com>, Qiang Zhao <qiang.zhao@....com>, Kumar Gala <galak@...eaurora.org>, Santosh Shilimkar <ssantosh@...nel.org>, Leo Li <leoyang.li@....com>, "X.B. Xie" <xiaobo.xie@....com>, "M.H. Lian" <minghuan.lian@....com> Subject: RE: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms > -----Original Message----- > From: Y.B. Lu > Sent: Friday, October 28, 2016 2:00 PM > To: 'Scott Wood'; linux-mmc@...r.kernel.org; ulf.hansson@...aro.org; Arnd > Bergmann > Cc: linuxppc-dev@...ts.ozlabs.org; devicetree@...r.kernel.org; linux-arm- > kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; linux- > clk@...r.kernel.org; linux-i2c@...r.kernel.org; iommu@...ts.linux- > foundation.org; netdev@...r.kernel.org; Greg Kroah-Hartman; Mark Rutland; > Rob Herring; Russell King; Jochen Friedrich; Joerg Roedel; Claudiu Manoil; > Bhupesh Sharma; Qiang Zhao; Kumar Gala; Santosh Shilimkar; Leo Li; X.B. > Xie; M.H. Lian > Subject: RE: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms > > > > > -----Original Message----- > > From: linux-mmc-owner@...r.kernel.org [mailto:linux-mmc- > > owner@...r.kernel.org] On Behalf Of Scott Wood > > Sent: Friday, October 28, 2016 12:46 PM > > To: Y.B. Lu; linux-mmc@...r.kernel.org; ulf.hansson@...aro.org; Arnd > > Bergmann > > Cc: linuxppc-dev@...ts.ozlabs.org; devicetree@...r.kernel.org; > > linux-arm- kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; > > linux- clk@...r.kernel.org; linux-i2c@...r.kernel.org; > > iommu@...ts.linux- foundation.org; netdev@...r.kernel.org; Greg > > Kroah-Hartman; Mark Rutland; Rob Herring; Russell King; Jochen > > Friedrich; Joerg Roedel; Claudiu Manoil; Bhupesh Sharma; Qiang Zhao; > Kumar Gala; Santosh Shilimkar; Leo Li; X.B. > > Xie; M.H. Lian > > Subject: Re: [v13, 5/8] soc: fsl: add GUTS driver for QorIQ platforms > > > > On Fri, 2016-10-28 at 11:32 +0800, Yangbo Lu wrote: > > > + guts->regs = of_iomap(np, 0); > > > + if (!guts->regs) > > > + return -ENOMEM; > > > + > > > + /* Register soc device */ > > > + machine = of_flat_dt_get_machine_name(); > > > + if (machine) > > > + soc_dev_attr.machine = devm_kstrdup(dev, machine, > > > GFP_KERNEL); > > > + > > > + svr = fsl_guts_get_svr(); > > > + soc_die = fsl_soc_die_match(svr, fsl_soc_die); > > > + if (soc_die) { > > > + soc_dev_attr.family = devm_kasprintf(dev, GFP_KERNEL, > > > + "QorIQ %s", soc_die- > > > >die); > > > + } else { > > > + soc_dev_attr.family = devm_kasprintf(dev, GFP_KERNEL, > > > "QorIQ"); > > > + } > > > + soc_dev_attr.soc_id = devm_kasprintf(dev, GFP_KERNEL, > > > + "svr:0x%08x", svr); > > > + soc_dev_attr.revision = devm_kasprintf(dev, GFP_KERNEL, "%d.%d", > > > + SVR_MAJ(svr), SVR_MIN(svr)); > > > + > > > + soc_dev = soc_device_register(&soc_dev_attr); > > > + if (IS_ERR(soc_dev)) > > > + return PTR_ERR(soc_dev); > > > > ioremap leaks on this error path. Use devm_ioremap_resource(). > > > > [Lu Yangbo-B47093] Ok. I have fixed it in v14. Thanks :) [Lu Yangbo-B47093] Sorry, used the wrong error code... Will resent it > > > -Scott > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-mmc" > > in the body of a message to majordomo@...r.kernel.org More majordomo > > info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists