lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 13 Nov 2016 12:00:15 -0500 (EST) From: David Miller <davem@...emloft.net> To: bjorn@...k.no Cc: plz@....fi, netdev@...r.kernel.org Subject: Re: [PATCH] Fixup packets with incorrect ethertype sent by ZTE MF821D From: Bjørn Mork <bjorn@...k.no> Date: Sun, 13 Nov 2016 17:12:57 +0100 > In any case, if we're going to add a fix like this, then I want it way > more generic. The only valid ethertypes expected from the modem is IP, > IPV6 or ARP. Testing against those three, resetting anything else to IP, > will at least catch *any* bogus value. > > But I'm not convinced I want this additional processing of every packet > just to let Qualcomm go on hiring monkeys-on-crack to write their > firmware. At least not when we do have raw-ip as a workaround for the > issue. > > Feel free to try to convince me, though. There are also several coding style problems with this patch.
Powered by blists - more mailing lists