netdev - Re: [patch net-next v2 0/8] Add support for offloading packet-sampling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Nov 2016 10:27:43 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     netdev@...r.kernel.org
Cc:     davem@...emloft.net, yotamg@...lanox.com, idosch@...lanox.com,
        eladr@...lanox.com, nogahf@...lanox.com, ogerlitz@...lanox.com,
        jhs@...atatu.com, geert+renesas@...der.be,
        stephen@...workplumber.org, xiyou.wangcong@...il.com,
        linux@...ck-us.net, roopa@...ulusnetworks.com,
        john.fastabend@...il.com, simon.horman@...ronome.com
Subject: Re: [patch net-next v2 0/8]  Add support for offloading
 packet-sampling

Mon, Nov 14, 2016 at 04:00:30PM CET, jiri@...nulli.us wrote:
>From: Jiri Pirko <jiri@...lanox.com>
>
>Add the sample tc action, which allows to sample packet matching
>a classifier. The sample action peeks randomly packets, duplicates them,
>truncates them and adds informative metadata on the packet, for example,
>the input interface and the original packet length. The sampled packets
>are marked to allow matching them and redirecting them to a specific
>collector device.
>
>The sampled packets metadata is packed using ife encapsulation. To do
>that, this patch-set extracts ife logics from the tc_ife action into an
>independent ife module, and uses that functionality to pack the metadata.
>To include all the needed metadata, this patch-set introduces some new
>IFE_META tlv types.
>
>In addition, Add the support for offloading the macthall-sample tc command
>in the Mellanox mlxsw driver, for ingress qdiscs.
>
>Userspace examples for that code can be found in:
> - https://github.com/yotamgi/host-sflow: sflow client that uses the sample
>   with combination of tap device to sample packets and send to a
>   centralized sflow collector.
> - https://github.com/yotamgi/libife: a library for manipulating ife
>   packets in userspace. The library is used in the host-sflow program to
>   parse the sampled packets.

Dave, please drop this patchset for now. We just discovered couple of
more changes are needed.

Thanks