netdev - Re: [PATCH] iproute2: Nr. of packets and octets for macsec tx stats were swapped.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Nov 2016 14:56:22 +0100
From:   Sabrina Dubroca <sd@...asysnail.net>
To:     Daniel.Hopf@...tinental-corporation.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] iproute2: Nr. of packets and octets for macsec tx stats
 were swapped.

Hi Daniel,

Thanks for fixing this. I noticed it some time ago but it seems
I forgot to send the patch :(

Acked-by: Sabrina Dubroca <sd@...asysnail.net>

Your subject line should be:

Subject: [PATCH iproute2] macsec: Nr.of packets and octets for macsec tx stats were swapped.

with "iproute2" between the brackets.

2016-11-22, 14:24:40 +0100, Daniel.Hopf@...tinental-corporation.com wrote:
> Signed-off-by: Daniel Hopf <daniel.hopf@...tinental-corporation.com>
> ---
>  ip/ipmacsec.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/ip/ipmacsec.c b/ip/ipmacsec.c
> index c9252bb..aa89a00 100644
> --- a/ip/ipmacsec.c
> +++ b/ip/ipmacsec.c
> @@ -634,10 +634,10 @@ static void print_one_stat(const char **names, 
> struct rtattr **attr, int idx,
>  }
> 
>  static const char *txsc_stats_names[NUM_MACSEC_TXSC_STATS_ATTR] = {
> -       [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_PROTECTED] = 
> "OutOctetsProtected",
> -       [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_ENCRYPTED] = 
> "OutOctetsEncrypted",
> -       [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_PROTECTED] = 
> "OutPktsProtected",
> -       [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_ENCRYPTED] = 
> "OutPktsEncrypted",
> +       [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_PROTECTED] = "OutPktsProtected",
> +       [MACSEC_TXSC_STATS_ATTR_OUT_PKTS_ENCRYPTED] = "OutPktsEncrypted",
> +       [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_PROTECTED] = 
> "OutOctetsProtected",
> +       [MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_ENCRYPTED] = 
> "OutOctetsEncrypted",
>  };

Your patch was corrupted, probably by your email client, you have
extra newlines everywhere.
Can you send a v2 of this patch? Thanks!

-- 
Sabrina