netdev - Re: [PATCH] cpsw: ethtool: add support for getting/setting EEE registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Nov 2016 16:31:09 +0200
From:   Rami Rosen <roszenrami@...il.com>
To:     yegorslists@...glemail.com
Cc:     Netdev <netdev@...r.kernel.org>,
        Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
        grygorii.strashko@...com, mugunthanvnm@...com
Subject: Re: [PATCH] cpsw: ethtool: add support for getting/setting EEE registers

Hi, Yegor,

Minor comment: these methods should be static.

+int cpsw_get_eee(struct net_device *ndev, struct ethtool_eee *edata)
+{
...
...
+int cpsw_set_eee(struct net_device *ndev, struct ethtool_eee *edata)
...

Regards,
Rami Rosen