lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 25 Nov 2016 20:53:50 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ubraun@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
        utz.bacher@...ibm.com
Subject: Re: [PATCH V3 net-next 05/15] smc: CLC handshake (incl.
 preparation steps)

From: Ursula Braun <ubraun@...ux.vnet.ibm.com>
Date: Thu, 24 Nov 2016 16:06:35 +0100

> +struct smc_clc_msg_hdr {	/* header1 of clc messages */
> +	u8 eyecatcher[4];	/* eye catcher */
> +	u8 type;		/* proposal / accept / confirm / decline */
> +	__be16 length;
> +#if defined(__BIG_ENDIAN_BITFIELD)
> +	u8 version : 4,
> +	   flag    : 1,
> +	   rsvd	   : 3;
> +#elif defined(__LITTLE_ENDIAN_BITFIELD)
> +	u8 rsvd    : 3,
> +	   flag    : 1,
> +	   version : 4;
> +#endif
> +} __packed;

Please get rid of all of these __packed attributes.  They are likely
completely unnecessary and the code generated for this construct on
certain architectures is amazingly inefficient.

Describe the on-wire datastructures properly with fixed sized types
and any padding or overlapping, as needed.

Powered by blists - more mailing lists