netdev - Re: [PATCH net-next 09/11] qede: Better utilize the qede_[rt]x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 27 Nov 2016 23:51:37 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Yuval Mintz <Yuval.Mintz@...ium.com>
Cc:     kbuild-all@...org, davem@...emloft.net, netdev@...r.kernel.org,
        Yuval Mintz <Yuval.Mintz@...ium.com>
Subject: Re: [PATCH net-next 09/11] qede: Better utilize the qede_[rt]x_queue

Hi Yuval,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Yuval-Mintz/qed-Add-XDP-support/20161127-225956
config: tile-allmodconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 4.6.2
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=tile 

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/qlogic/qede/qede_main.c: In function 'qede_alloc_mem_rxq':
>> drivers/net/ethernet/qlogic/qede/qede_main.c:2960:3: warning: large integer implicitly truncated to unsigned type [-Woverflow]

vim +2960 drivers/net/ethernet/qlogic/qede/qede_main.c

55482edc Manish Chopra 2016-03-04  2944  err:
55482edc Manish Chopra 2016-03-04  2945  	qede_free_sge_mem(edev, rxq);
55482edc Manish Chopra 2016-03-04  2946  	edev->gro_disable = 1;
55482edc Manish Chopra 2016-03-04  2947  	return -ENOMEM;
55482edc Manish Chopra 2016-03-04  2948  }
55482edc Manish Chopra 2016-03-04  2949  
2950219d Yuval Mintz   2015-10-26  2950  /* This function allocates all memory needed per Rx queue */
1a635e48 Yuval Mintz   2016-08-15  2951  static int qede_alloc_mem_rxq(struct qede_dev *edev, struct qede_rx_queue *rxq)
2950219d Yuval Mintz   2015-10-26  2952  {
f86af2df Manish Chopra 2016-04-20  2953  	int i, rc, size;
2950219d Yuval Mintz   2015-10-26  2954  
2950219d Yuval Mintz   2015-10-26  2955  	rxq->num_rx_buffers = edev->q_num_rx_buffers;
2950219d Yuval Mintz   2015-10-26  2956  
1a635e48 Yuval Mintz   2016-08-15  2957  	rxq->rx_buf_size = NET_IP_ALIGN + ETH_OVERHEAD + edev->ndev->mtu;
1a635e48 Yuval Mintz   2016-08-15  2958  
fc48b7a6 Yuval Mintz   2016-02-15  2959  	if (rxq->rx_buf_size > PAGE_SIZE)
fc48b7a6 Yuval Mintz   2016-02-15 @2960  		rxq->rx_buf_size = PAGE_SIZE;
fc48b7a6 Yuval Mintz   2016-02-15  2961  
fc48b7a6 Yuval Mintz   2016-02-15  2962  	/* Segment size to spilt a page in multiple equal parts */
fc48b7a6 Yuval Mintz   2016-02-15  2963  	rxq->rx_buf_seg_size = roundup_pow_of_two(rxq->rx_buf_size);
2950219d Yuval Mintz   2015-10-26  2964  
2950219d Yuval Mintz   2015-10-26  2965  	/* Allocate the parallel driver ring for Rx buffers */
fc48b7a6 Yuval Mintz   2016-02-15  2966  	size = sizeof(*rxq->sw_rx_ring) * RX_RING_SIZE;
2950219d Yuval Mintz   2015-10-26  2967  	rxq->sw_rx_ring = kzalloc(size, GFP_KERNEL);
2950219d Yuval Mintz   2015-10-26  2968  	if (!rxq->sw_rx_ring) {

:::::: The code at line 2960 was first introduced by commit
:::::: fc48b7a6148af974b49db145812a8b060324a503 qed/qede: use 8.7.3.0 FW.

:::::: TO: Yuval Mintz <Yuval.Mintz@...gic.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (46485 bytes)