netdev - Re: [PATCH] ehea: Remove unnecessary memset of stats in netdev private data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Nov 2016 14:26:45 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tklauser@...tanz.ch
Cc:     dougmill@...ux.vnet.ibm.com, netdev@...r.kernel.org
Subject: Re: [PATCH] ehea: Remove unnecessary memset of stats in netdev
 private data

From: Tobias Klauser <tklauser@...tanz.ch>
Date: Tue, 29 Nov 2016 14:35:07 +0100

> The memory for netdev private data is allocated using kzalloc/vzalloc in
> alloc_netdev_mqs, thus there is no need to zero the stats portion of it
> again in the driver's probe function.
> 
> In any case, the size for the memset is wrong as the stats member is of
> type rtnl_link_stats64, not net_device_stats.
> 
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>

Applied, thanks.