netdev - Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Dec 2016 12:47:16 -0600
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>, <mugunthanvnm@...com>
CC:     <linux-omap@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process
 instead of raw read



On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote:
> There is desc_read() macros to read desc fields, so no need to
> use __raw_readl();
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>


I'm going to update it all at once as part of [1].

[1] https://lkml.org/lkml/2016/12/1/781

> ---
> Based on net-next/master
>
>  drivers/net/ethernet/ti/davinci_cpdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
> index c776e45..d96dca5 100644
> --- a/drivers/net/ethernet/ti/davinci_cpdma.c
> +++ b/drivers/net/ethernet/ti/davinci_cpdma.c
> @@ -1132,7 +1132,7 @@ static int __cpdma_chan_process(struct cpdma_chan *chan)
>  	}
>  	desc_dma = desc_phys(pool, desc);
>
> -	status	= __raw_readl(&desc->hw_mode);
> +	status = desc_read(desc, hw_mode);
>  	outlen	= status & 0x7ff;
>  	if (status & CPDMA_DESC_OWNER) {
>  		chan->stats.busy_dequeue++;
>

-- 
regards,
-grygorii