netdev - Re: commit : ppp: add rtnetlink device creation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Dec 2016 09:28:19 +0800
From:   Brad Campbell <lists2009@...rfbargle.com>
To:     Guillaume Nault <g.nault@...halink.fr>
Cc:     netdev <netdev@...r.kernel.org>
Subject: Re: commit : ppp: add rtnetlink device creation support - breaks
 netcf on my machine.

On 06/12/16 01:53, Guillaume Nault wrote:

> Can you send a minimal configuration file that triggers the bug?
> I've set up a virtual machine (Linux 4.7.0, netcf 0.2.8 backported from
> Debian Sid), but couldn't reproduce the issue so far.
>

Ok I reproduced this in a VM. I used the stock Debian 7 install netcf 
version 0.1.9 which exhibits the fault just as well, so no backporting 
required.

The server is (as before) a Debian 7.11 box.
I downloaded rp-pppoe and compiled it up on the server.

Moved into the rp-pppoe-3.12/src directory.
Created these two files :
root@srv:~/src/rp-pppoe-3.12/src# cat allip
10.0.1.2-200

root@srv:~/src/rp-pppoe-3.12/src# cat pppoe-server-options
#require-pap
noauth
lcp-echo-interval 10
lcp-echo-failure 2
ms-dns 192.168.2.1
netmask 255.255.255.0
usepeerdns
nobsdcomp
noccp
novj
noipx

And ran the server :
./pppoe-server -I br1 -C isp -S jimmy -L 10.0.1.1 -O 
`pwd`/pppoe-server-options -p `pwd`/allip -q /usr/sbin/pppd -Q 
`pwd`/pppoe -F

The VM is a stock Debian VM installed from the Debian 7.5 netinst and 
upgraded to the latest packages. The VM is run on KVM and the network 
interface is bound to br2.

Install ppp and netcf. Created :
root@...ian64:/home/brad# cat /etc/ppp/peers/dsl-provider
debug
noipdefault
noauth
persist
maxfail 0
plugin rp-pppoe.so eth0

And added the following to /etc/network/interfaces:

auto dsl-provider
iface dsl-provider inet ppp
	provider dsl-provider

With the stock debian kernel this brings up the ppp0 interface, and 
ncftool works fine.

I compiled up a 4.8.12 kernel with the attached config (static kernel, 
no modules) resulting in :

root@...ian64:/home/brad# ifdown dsl-provider
root@...ian64:/home/brad# ifconfig
eth0      Link encap:Ethernet  HWaddr 52:54:00:ae:c0:74
           inet addr:192.168.253.50  Bcast:192.168.253.255 
Mask:255.255.255.0
           UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
           RX packets:1841 errors:0 dropped:0 overruns:0 frame:0
           TX packets:674 errors:0 dropped:0 overruns:0 carrier:0
           collisions:0 txqueuelen:1000
           RX bytes:230980 (225.5 KiB)  TX bytes:99559 (97.2 KiB)

lo        Link encap:Local Loopback
           inet addr:127.0.0.1  Mask:255.0.0.0
           UP LOOPBACK RUNNING  MTU:65536  Metric:1
           RX packets:0 errors:0 dropped:0 overruns:0 frame:0
           TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
           collisions:0 txqueuelen:1
           RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)

root@...ian64:/home/brad# ncftool
ncftool> quit
root@...ian64:/home/brad# ifup dsl-provider
Plugin rp-pppoe.so loaded.
root@...ian64:/home/brad# ifconfig
eth0      Link encap:Ethernet  HWaddr 52:54:00:ae:c0:74
           inet addr:192.168.253.50  Bcast:192.168.253.255 
Mask:255.255.255.0
           UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
           RX packets:1949 errors:0 dropped:0 overruns:0 frame:0
           TX packets:741 errors:0 dropped:0 overruns:0 carrier:0
           collisions:0 txqueuelen:1000
           RX bytes:240006 (234.3 KiB)  TX bytes:110717 (108.1 KiB)

lo        Link encap:Local Loopback
           inet addr:127.0.0.1  Mask:255.0.0.0
           UP LOOPBACK RUNNING  MTU:65536  Metric:1
           RX packets:0 errors:0 dropped:0 overruns:0 frame:0
           TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
           collisions:0 txqueuelen:1
           RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)

ppp0      Link encap:Point-to-Point Protocol
           inet addr:10.0.1.3  P-t-P:10.0.1.1  Mask:255.255.255.255
           UP POINTOPOINT RUNNING NOARP MULTICAST  MTU:1492  Metric:1
           RX packets:4 errors:0 dropped:0 overruns:0 frame:0
           TX packets:4 errors:0 dropped:0 overruns:0 carrier:0
           collisions:0 txqueuelen:3
           RX bytes:52 (52.0 B)  TX bytes:46 (46.0 B)

root@...ian64:/home/brad# ncftool
Failed to initialize netcf

Hope this helps.

Regards,
Brad

View attachment "config.4.8.12.ppp.static" of type "text/plain" (43097 bytes)