netdev - Re: [PATCH V2 21/22] bnxt_re: Add QP event handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Dec 2016 15:12:14 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Selvin Xavier <selvin.xavier@...adcom.com>, dledford@...hat.com,
        linux-rdma@...r.kernel.org
Cc:     netdev@...r.kernel.org, Eddie Wai <eddie.wai@...adcom.com>,
        Devesh Sharma <devesh.sharma@...adcom.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>
Subject: Re: [PATCH V2 21/22] bnxt_re: Add QP event handling

Hello!

On 12/9/2016 9:48 AM, Selvin Xavier wrote:

> Implements callback handler for processing affiliated Async events of a QP.
> This patch also implements the control path command completion handling.
>
> Signed-off-by: Eddie Wai <eddie.wai@...adcom.com>
> Signed-off-by: Devesh Sharma <devesh.sharma@...adcom.com>
> Signed-off-by: Somnath Kotur <somnath.kotur@...adcom.com>
> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>
> Signed-off-by: Selvin Xavier <selvin.xavier@...adcom.com>
> ---
>  drivers/infiniband/hw/bnxtre/bnxt_qplib_rcfw.c | 49 ++++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
>
> diff --git a/drivers/infiniband/hw/bnxtre/bnxt_qplib_rcfw.c b/drivers/infiniband/hw/bnxtre/bnxt_qplib_rcfw.c
> index 5b71acd..3e6bb3f 100644
> --- a/drivers/infiniband/hw/bnxtre/bnxt_qplib_rcfw.c
> +++ b/drivers/infiniband/hw/bnxtre/bnxt_qplib_rcfw.c
> @@ -246,6 +246,46 @@ static int bnxt_qplib_process_func_event(struct bnxt_qplib_rcfw *rcfw,
>  	return 0;
>  }
>
> +static int bnxt_qplib_process_qp_event(struct bnxt_qplib_rcfw *rcfw,
> +				       struct creq_qp_event *qp_event)
> +{
> +	struct bnxt_qplib_crsq *crsq = &rcfw->crsq;
> +	struct bnxt_qplib_hwq *cmdq = &rcfw->cmdq;
> +	struct bnxt_qplib_crsqe *crsqe;
> +	u16 cbit, cookie, blocked = 0;
> +	unsigned long flags;
> +	u32 sw_cons;
> +
> +	switch (qp_event->event) {
> +	case CREQ_QP_EVENT_EVENT_QP_ERROR_NOTIFICATION:
> +		break;
> +	default:
> +	{
> +		/* Command Response */
> +		spin_lock_irqsave(&cmdq->lock, flags);
> +		sw_cons = HWQ_CMP(crsq->cons, crsq);
> +		crsqe = &crsq->crsq[sw_cons];
> +		crsq->cons++;
> +		memcpy(&crsqe->qp_event, qp_event, sizeof(crsqe->qp_event));
> +
> +		cookie = le16_to_cpu(crsqe->qp_event.cookie);
> +		blocked = cookie & RCFW_CMD_IS_BLOCKING;
> +		cookie &= RCFW_MAX_COOKIE_VALUE;
> +		cbit = cookie % RCFW_MAX_OUTSTANDING_CMD;
> +		if (!test_and_clear_bit(cbit, rcfw->cmdq_bitmap))
> +			dev_warn(&rcfw->pdev->dev,
> +				 "QPLIB: CMD bit %d was not requested", cbit);
> +
> +		cmdq->cons += crsqe->req_size;
> +		spin_unlock_irqrestore(&cmdq->lock, flags);
> +		if (!blocked)
> +			wake_up(&rcfw->waitq);
> +		break;
> +	}
> +	}

    Hum, strange indentation... Not seeing why you need {} in the *default* at 
all...

> +	return 0;
> +}
> +
>  /* SP - CREQ Completion handlers */
>  static void bnxt_qplib_service_creq(unsigned long data)
>  {
> @@ -269,6 +309,15 @@ static void bnxt_qplib_service_creq(unsigned long data)
>  		type = creqe->type & CREQ_BASE_TYPE_MASK;
>  		switch (type) {
>  		case CREQ_BASE_TYPE_QP_EVENT:
> +			if (!bnxt_qplib_process_qp_event
> +			    (rcfw, (struct creq_qp_event *)creqe))
> +				rcfw->creq_qp_event_processed++;
> +			else {

    CodingStyle: there should be {} used in all branches if it's used on at 
least branch of *if*.

> +				dev_warn(&rcfw->pdev->dev, "QPLIB: crsqe with");
> +				dev_warn(&rcfw->pdev->dev,
> +					 "QPLIB: type = 0x%x not handled",
> +					 type);
> +			}
>  			break;
>  		case CREQ_BASE_TYPE_FUNC_EVENT:
>  			if (!bnxt_qplib_process_func_event

MBR, Sergei