lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 10 Dec 2016 09:47:45 -0800 From: David Ahern <dsa@...ulusnetworks.com> To: netdev@...r.kernel.org, stephen@...workplumber.org Cc: David Ahern <dsa@...ulusnetworks.com> Subject: [iproute2 net-next 4/8] move cmd_exec to lib utils Signed-off-by: David Ahern <dsa@...ulusnetworks.com> --- include/utils.h | 2 ++ ip/ipnetns.c | 34 ---------------------------------- lib/Makefile | 2 +- lib/exec.c | 41 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 44 insertions(+), 35 deletions(-) create mode 100644 lib/exec.c diff --git a/include/utils.h b/include/utils.h index 26c970daa5d0..ac4517a3bde1 100644 --- a/include/utils.h +++ b/include/utils.h @@ -256,4 +256,6 @@ char *int_to_str(int val, char *buf); int get_guid(__u64 *guid, const char *arg); int get_real_family(int rtm_type, int rtm_family); +int cmd_exec(const char *cmd, char **argv, bool do_fork); + #endif /* __UTILS_H__ */ diff --git a/ip/ipnetns.c b/ip/ipnetns.c index bd1e9013706c..db9a541769f1 100644 --- a/ip/ipnetns.c +++ b/ip/ipnetns.c @@ -357,40 +357,6 @@ static int netns_list(int argc, char **argv) return 0; } -static int cmd_exec(const char *cmd, char **argv, bool do_fork) -{ - fflush(stdout); - if (do_fork) { - int status; - pid_t pid; - - pid = fork(); - if (pid < 0) { - perror("fork"); - exit(1); - } - - if (pid != 0) { - /* Parent */ - if (waitpid(pid, &status, 0) < 0) { - perror("waitpid"); - exit(1); - } - - if (WIFEXITED(status)) { - return WEXITSTATUS(status); - } - - exit(1); - } - } - - if (execvp(cmd, argv) < 0) - fprintf(stderr, "exec of \"%s\" failed: %s\n", - cmd, strerror(errno)); - _exit(1); -} - static int on_netns_exec(char *nsname, void *arg) { char **argv = arg; diff --git a/lib/Makefile b/lib/Makefile index 5b7ec169048a..749073261c49 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -8,7 +8,7 @@ CFLAGS += -fPIC UTILOBJ = utils.o rt_names.o ll_types.o ll_proto.o ll_addr.o \ inet_proto.o namespace.o json_writer.o \ - names.o color.o bpf.o + names.o color.o bpf.o exec.o NLOBJ=libgenl.o ll_map.o libnetlink.o diff --git a/lib/exec.c b/lib/exec.c new file mode 100644 index 000000000000..96edbc422e84 --- /dev/null +++ b/lib/exec.c @@ -0,0 +1,41 @@ +#define _ATFILE_SOURCE +#include <sys/wait.h> +#include <stdio.h> +#include <errno.h> +#include <unistd.h> + +#include "utils.h" + +int cmd_exec(const char *cmd, char **argv, bool do_fork) +{ + fflush(stdout); + if (do_fork) { + int status; + pid_t pid; + + pid = fork(); + if (pid < 0) { + perror("fork"); + exit(1); + } + + if (pid != 0) { + /* Parent */ + if (waitpid(pid, &status, 0) < 0) { + perror("waitpid"); + exit(1); + } + + if (WIFEXITED(status)) { + return WEXITSTATUS(status); + } + + exit(1); + } + } + + if (execvp(cmd, argv) < 0) + fprintf(stderr, "exec of \"%s\" failed: %s\n", + cmd, strerror(errno)); + _exit(1); +} -- 2.1.4
Powered by blists - more mailing lists