netdev - Re: [PATCH] vhost/vsock: Remove unused but set variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 15 Dec 2016 06:54:58 +0200
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Tobias Klauser <tklauser@...tanz.ch>
Cc:     Stefan Hajnoczi <stefanha@...hat.com>,
        Jason Wang <jasowang@...hat.com>, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH] vhost/vsock: Remove unused but set variable

On Fri, Nov 11, 2016 at 02:26:31PM +0100, Tobias Klauser wrote:
> Remove the unused but set variable vq in vhost_transport_send_pkt() to
> fix the following GCC warning when building with 'W=1':
> 
>   drivers/vhost/vsock.c:198:26: warning: variable ‘vq’ set but not used
> 
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>

doesn't apply anymore.

> ---
>  drivers/vhost/vsock.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
> index e3b30ea9ece5..9c3c68b9a49e 100644
> --- a/drivers/vhost/vsock.c
> +++ b/drivers/vhost/vsock.c
> @@ -195,7 +195,6 @@ static int
>  vhost_transport_send_pkt(struct virtio_vsock_pkt *pkt)
>  {
>  	struct vhost_vsock *vsock;
> -	struct vhost_virtqueue *vq;
>  	int len = pkt->len;
>  
>  	/* Find the vhost_vsock according to guest context id  */
> @@ -205,8 +204,6 @@ vhost_transport_send_pkt(struct virtio_vsock_pkt *pkt)
>  		return -ENODEV;
>  	}
>  
> -	vq = &vsock->vqs[VSOCK_VQ_RX];
> -
>  	if (pkt->reply)
>  		atomic_inc(&vsock->queued_replies);
>  
> -- 
> 2.11.0.rc0.7.gbe5a750
>