netdev - [PATCH] net: ipv4: tcp_offload: check segs for NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Dec 2016 14:17:41 +0530
From:   shakya.das@...sung.com
To:     davem@...emloft.net
Cc:     netdev@...r.kernel.org, shakya89.das@...il.com,
        vidushi.koul@...sung.com
Subject: [PATCH] net: ipv4: tcp_offload: check segs for NULL

From: Shakya Sundar Das <shakya.das@...sung.com>

This patch will check segs for being NULL in tcp_gso_segment()
before calling skb_shinfo(segs) from skb_is_gso(segs), otherwise
kernel can run into a NULL-pointer dereference.

Signed-off-by: Shakya Sundar Das <shakya.das@...sung.com>
---
 net/ipv4/tcp_offload.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/tcp_offload.c b/net/ipv4/tcp_offload.c
index bc68da3..93feefd 100644
--- a/net/ipv4/tcp_offload.c
+++ b/net/ipv4/tcp_offload.c
@@ -96,7 +96,7 @@ struct sk_buff *tcp_gso_segment(struct sk_buff *skb,
 	skb->ooo_okay = 0;
 
 	segs = skb_segment(skb, features);
-	if (IS_ERR(segs))
+	if (IS_ERR_OR_NULL(segs))
 		goto out;
 
 	/* Only first segment might have ooo_okay set */
-- 
1.7.9.5