lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Dec 2016 15:52:27 +0100 From: Andrew Lunn <andrew@...n.ch> To: Romain Perier <romain.perier@...e-electrons.com> Cc: Vivien Didelot <vivien.didelot@...oirfairelinux.com>, Florian Fainelli <f.fainelli@...il.com>, Jason Cooper <jason@...edaemon.net>, Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, Gregory Clement <gregory.clement@...e-electrons.com>, netdev@...r.kernel.org, devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Kumar Gala <galak@...eaurora.org>, linux-arm-kernel@...ts.infradead.org, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>, Nadav Haklai <nadavh@...vell.com> Subject: Re: [PATCH 3/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341/88E6141 Hi Romain > diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c > index 76d944e..72ba24b 100644 > --- a/drivers/net/dsa/mv88e6xxx/chip.c > +++ b/drivers/net/dsa/mv88e6xxx/chip.c > @@ -4086,6 +4086,20 @@ static const struct mv88e6xxx_info mv88e6xxx_table[] = { > .ops = &mv88e6321_ops, > }, > > + [MV88E6341] = { > + .prod_num = PORT_SWITCH_ID_PROD_NUM_6341, > + .family = MV88E6XXX_FAMILY_6352, > + .name = "Marvell 88E6341", > + .num_databases = 4096, > + .num_ports = 6, > + .port_base_addr = 0x10, > + .global1_addr = 0x1b, > + .age_time_coeff = 15000, > + .tag_protocol = DSA_TAG_PROTO_EDSA, > + .flags = MV88E6XXX_FLAGS_FAMILY_6352, > + .ops = &mv88e6352_ops, Even if it i 100% compatible with the 6532, you should still add an ops structure for it. All chips have their own, even when the are exactly the same as other in the family. > --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > @@ -86,6 +86,7 @@ > #define PORT_SWITCH_ID_PROD_NUM_6097 0x099 > #define PORT_SWITCH_ID_PROD_NUM_6131 0x106 > #define PORT_SWITCH_ID_PROD_NUM_6320 0x115 > +#define PORT_SWITCH_ID_PROD_NUM_6341 0x340 > #define PORT_SWITCH_ID_PROD_NUM_6123 0x121 > #define PORT_SWITCH_ID_PROD_NUM_6161 0x161 Ah, err.. These should be in numerical order of the macro. PORT_SWITCH_ID_PROD_NUM_6320 is however in the wrong place. Please put the 6341 after the 6321. Thanks Andrew
Powered by blists - more mailing lists