[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1482446511.8944.81.camel@edumazet-glaptop3.roam.corp.google.com>
Date: Thu, 22 Dec 2016 14:41:51 -0800
From: Eric Dumazet <eric.dumazet@...il.com>
To: Josef Bacik <jbacik@...com>
Cc: davem@...emloft.net, hannes@...essinduktion.org,
kraigatgoog@...il.com, tom@...bertland.com, netdev@...r.kernel.org,
kernel-team@...com
Subject: Re: [PATCH 3/6 net-next] inet: kill smallest_size and smallest_port
On Thu, 2016-12-22 at 16:26 -0500, Josef Bacik wrote:
> In inet_csk_get_port we seem to be using smallest_port to figure out where the
> best place to look for a SO_REUSEPORT sk that matches with an existing set of
> SO_REUSEPORT's. However if we get to the logic
>
> if (smallest_size != -1) {
> port = smallest_port;
> goto have_port;
> }
>
> we will do a useless search, because we would have already done the
> inet_csk_bind_conflict for that port and it would have returned 1, otherwise we
> would have gone to found_tb and succeeded. Since this logic makes us do yet
> another trip through inet_csk_bind_conflict for a port we know won't work just
> delete this code and save us the time.
>
> Signed-off-by: Josef Bacik <jbacik@...com>
Please remove tb->need_owners ;)
Powered by blists - more mailing lists