netdev - Re: [Open-FCoE] [PATCH RFC 3/5] qedf: Add offloaded I/O request functions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Dec 2016 10:08:09 +0100
From:   Hannes Reinecke <hare@...e.de>
To:     "Dupuis, Chad" <chad.dupuis@...ium.com>, martin.petersen@...cle.com
Cc:     fcoe-devel@...n-fcoe.org, netdev@...r.kernel.org,
        QLogic-Storage-Upstream@...ium.com, linux-scsi@...r.kernel.org,
        yuval.mintz@...ium.com
Subject: Re: [Open-FCoE] [PATCH RFC 3/5] qedf: Add offloaded I/O request
 functions.

On 12/23/2016 08:17 PM, Dupuis, Chad wrote:
> From: "Dupuis, Chad" <chad.dupuis@...ium.com>
> 
> This patch adds various I/O requests types that are handled in firmware:
> 
> - Normal I/O requests
> - ABTS requests
> - Cleanup requests
> - Task management requests
> 
> It also contains:
> 
> - I/O request initialization
> - Firmware completion handling
> 
> Signed-off-by: Nilesh Javali <nilesh.javali@...ium.com>
> Signed-off-by: Manish Rangankar <manish.rangankar@...ium.com>
> Signed-off-by: Saurav Kashyap <saurav.kashyap@...ium.com>
> Signed-off-by: Chad Dupuis <chad.dupuis@...ium.com>
> ---
>  drivers/scsi/qedf/qedf_hsi.h |  427 ++++++++
>  drivers/scsi/qedf/qedf_io.c  | 2303 ++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 2730 insertions(+)
>  create mode 100644 drivers/scsi/qedf/qedf_hsi.h
>  create mode 100644 drivers/scsi/qedf/qedf_io.c
> 
[ .. ]

> +static int qedf_execute_tmf(struct qedf_rport *fcport, struct scsi_cmnd *sc_cmd,
> +	uint8_t tm_flags)
> +{
> +	struct qedf_ioreq *io_req;
> +	struct qedf_mp_req *tm_req;
> +	struct fcoe_task_context *task;
> +	struct fc_frame_header *fc_hdr;
> +	struct fcp_cmnd *fcp_cmnd;
> +	struct qedf_ctx *qedf = fcport->qedf;
> +	int rc = 0;
> +	uint16_t xid;
> +	uint32_t sid, did;
> +	int tmo = 0;
> +	unsigned long flags;
> +
> +	if (!sc_cmd) {
> +		QEDF_ERR(&(qedf->dbg_ctx), "invalid arg\n");
> +		return FAILED;
> +	}
> +
> +	if (!(test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags))) {
> +		QEDF_ERR(&(qedf->dbg_ctx), "fcport not offloaded\n");
> +		rc = FAILED;
> +		return FAILED;
> +	}
> +
> +	scsi_block_requests(qedf->lport->host);
> +
Typically, EH commands will be executed after the scsi host is stopped
and no commands are outstanding.
So there's no point in issuing 'scsi_block_requests()' here.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)