netdev - Re: [PATCH 1/1] r8169: fix the typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 30 Dec 2016 10:19:12 +0800
From:   Yanjun Zhu <yanjun.zhu@...cle.com>
To:     nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] r8169: fix the typo

Hi,

Please comment on this patch.

Zhu Yanjun

On 2016/12/29 11:11, Zhu Yanjun wrote:
> >From the realtek data sheet, the PID0 should be bit 0.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@...cle.com>
> ---
>   drivers/net/ethernet/realtek/r8169.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 44389c9..8f1623b 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -696,7 +696,7 @@ enum rtl_tx_desc_bit_1 {
>   enum rtl_rx_desc_bit {
>   	/* Rx private */
>   	PID1		= (1 << 18), /* Protocol ID bit 1/2 */
> -	PID0		= (1 << 17), /* Protocol ID bit 2/2 */
> +	PID0		= (1 << 17), /* Protocol ID bit 0/2 */
>   
>   #define RxProtoUDP	(PID1)
>   #define RxProtoTCP	(PID0)