netdev - Re: [PATCH] ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Dec 2016 15:23:25 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ptikhomirov@...tuozzo.com
Cc:     edumazet@...gle.com, kuznet@....inr.ac.ru, jmorris@...ei.org,
        yoshfuji@...ux-ipv6.org, kaber@...sh.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, khorenko@...tuozzo.com
Subject: Re: [PATCH] ipv4: make tcp_notsent_lowat sysctl knob behave as
 true unsigned int

From: Pavel Tikhomirov <ptikhomirov@...tuozzo.com>
Date: Thu, 29 Dec 2016 17:35:07 +0300

> @@ -958,7 +959,9 @@ static struct ctl_table ipv4_net_table[] = {
>  		.data		= &init_net.ipv4.sysctl_tcp_notsent_lowat,
>  		.maxlen		= sizeof(unsigned int),
>  		.mode		= 0644,
> -		.proc_handler	= proc_dointvec,
> +		.proc_handler	= proc_doulongvec_minmax,
> +		.extra1		= &zero,
> +		.extra2		= &uint_max,

It seems much simpler to use "proc_douintvec()" to fix this bug.

Doesn't it?