lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 30 Dec 2016 15:27:09 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     thomas.preisner+linux@....de
Cc:     dave@...dillows.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-kernel@...cs.fau.de,
        milan.stephan+linux@....de, sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH v4 1/2] net: 3com: typhoon: typhoon_init_one: fix
 incorrect return values

From: Thomas Preisner <thomas.preisner+linux@....de>
Date: Fri, 30 Dec 2016 03:37:53 +0100

> In a few cases the err-variable is not set to a negative error code if a
> function call in typhoon_init_one() fails and thus 0 is returned
> instead.
> It may be better to set err to the appropriate negative error
> code before returning.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188841
> 
> Reported-by: Pan Bian <bianpan2016@....com>
> Signed-off-by: Thomas Preisner <thomas.preisner+linux@....de>
> Signed-off-by: Milan Stephan <milan.stephan+linux@....de>

Applied to net-next.

Powered by blists - more mailing lists